Make "fill" module used by examples more useful + add an input tester example by wareya · Pull Request #4219 · rust-windowing/winit

wareya · 2025-05-08T21:17:53Z

Tested on all platforms changed
Added an entry to the changelog module if knowledge of this change could be valuable to users
Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
Created or updated an example program if it would help users understand this functionality

Dev-only change.

Adds a fill_window_with_fn function to the fill module (only used by examples, not winit's outward-facing API), which allows examples to graphically display real information instead of just a blank screen. However, softbuffer, used internally by the fill module, is very slow on certain platforms (web, mac os), so the usage of this new function should be limited to basic test-that-this-thing-works examples, and not used for "game" or "application" style examples. Also adds a dev dependency on font8x8 so that examples can easily display text.

Also adds an input tester example that uses the new function. The input tester is a low-complexity scribbling/drawing application. The tester is force-aware for Touch events when Touch force is supported.

The html file for the web version of the example has a fixed canvas size because of what seems to be a bug inside of softbuffer where it crashes on web if the width of the canvas is a weird value.

I tested the input tester tested on windows and web.

tester_2025-05-08_17-08-37.mp4

This was inspired by a tablet tester I made for locally testing whether my tablet support fork worked (not part of this PR)

tablet_2025-05-06_15-35-34.mp4

wareya · 2025-05-08T21:56:31Z

Huh, cargo-deny is failing onzerocopy 🤔 That's so weird...

wareya · 2025-05-08T23:25:08Z

ahash updated and now as of 0.8.12 depends on a newer version of zerocopy which is where the cargo deny error comes from.

madsmtm

I'm very much in favour of getting this in! Having examples that actually do something interesting would help a lot with debugging rendering issues, as well as figuring out API warts in general.

(And uh, I also didn't see this in my notifications, so similarly, feel free to ping me on Matrix if there's stuff I miss).

madsmtm · 2025-05-16T20:24:44Z

examples/tester.rs

+#[cfg(web_platform)]
+use wasm_bindgen::prelude::wasm_bindgen;
+#[cfg(web_platform)]
+#[wasm_bindgen(start)]


Nit: Is this still required? I thought that wasm-bindgen supported fn main nowadays?

I had trouble getting it to work properly with a normal fn main, don't know why.

madsmtm · 2025-05-16T20:26:10Z

Cargo.toml

 tracing = { version = "0.1.40", default-features = false }

 [dev-dependencies]
+font8x8 = "0.3.1"


Nit: Seems like this hasn't been updated in 4 years. Maybe there's something a bit more maintained we can use?

I considered it, but because it's "just" a font, I figured it probably wasn't that important that it's unmaintained 🤔 Maybe the decision between different debugging/embedded bitmap font crates could better be made based off of license or looks?

Actually, I think I found a potential snafu: the font data font8x8 is based on says it's public domain, but the maintainer/author seems to located in Germany, and there isn't a workaround license like CC0 to make up for the fact that "speech act" public domain dedications don't work under German law? This is almost certainly not a problem, but it COULD be one, hypothetically. Maybe I'll open an issue on it. https://github.com/dhepper/font8x8

madsmtm · 2025-05-16T20:27:55Z

Cargo.toml

+[target.'cfg(not(target_family = "wasm"))'.dev-dependencies]
+web-time = "1"


Nit: Slight preference for doing:

#[cfg(target_family = "wasm")] use web_time::Instant; #[cfg(not(target_family = "wasm"))] use std::time::Instant;

In example code too.

madsmtm · 2025-05-16T20:28:10Z

examples/tester.html

+    </head>
+    <body>
+    </body>
+</html>


Nit: Missing trailing newline

madsmtm · 2025-05-16T20:33:11Z

examples/tester.rs

@@ -0,0 +1,309 @@
+//! Basic winit interactivity example.


Nit: Maybe call the example something like interactivity.rs or drawing_app.rs?

Also, you can group stuff in a folder, like examples/drawing_app/main.rs + examples/drawing_app/index.html

madsmtm · 2025-05-16T20:35:42Z

examples/tester.rs

+                // Don't run hundreds of thousands of times per second even if the platform asks.
+                // (Can't sleep on web, so gated off there. Browsers won't ask for too much.)
+                #[cfg(not(web_platform))]
+                {
+                    std::thread::sleep(std::time::Duration::from_millis(1));
+                }


The fact that you currently need this kind of stuff is exactly why this example is so useful!

madsmtm · 2025-05-16T20:37:13Z

examples/tester.rs

+                                for _y in -(thickness as i32) / 2..(thickness as i32 + 1) / 2 {
+                                    for _x in -(thickness as i32) / 2..(thickness as i32 + 1) / 2 {


Nit: I prefer shadowing in these situations (use y instead of _y).

madsmtm · 2025-05-16T20:55:40Z

examples/util/fill.rs

+                    height: r[3].try_into().unwrap(),
+                })
+                .collect::<Vec<_>>();
+            buffer.present_with_damage(&rects).expect("Failed to present the softbuffer buffer");


It seems like you're reusing the buffer in your impl? That doesn't work unless buffer.age() == 1 (which it e.g. isn't on macOS).

Good catch!

wareya added 5 commits May 6, 2025 21:42

Add fill_window_with_fn and a sketch tester as an example for it

8a0cafa

add a spinning animation to make clear that the example isn't frozen

e3aa3e7

Support touch pressure + web in input tester example

bbe81af

Try to fix mistakes that CI complained about

d2d26e3

fix clippy and taplo complaints

c0308c4

wareya force-pushed the fillplus branch from d71e52b to 83fc1b0 Compare May 8, 2025 21:34

Oops, forgot to add nop version on ios/android

abe8185

wareya force-pushed the fillplus branch from 83fc1b0 to abe8185 Compare May 8, 2025 21:41

madsmtm added the S - docs Awareness, docs, examples, etc. label May 16, 2025

Mostly fix scale-factor

7d5a5a3

madsmtm reviewed May 16, 2025

View reviewed changes

wareya mentioned this pull request Aug 3, 2025

winit-core:winit: add tablet input support #4318

Merged

		[target.'cfg(not(target_family = "wasm"))'.dev-dependencies]
		web-time = "1"

+                  </head>
+                  <body>
+                  </body>
+              </html>

                
                    No newline at end of file

		for _y in -(thickness as i32) / 2..(thickness as i32 + 1) / 2 {
		for _x in -(thickness as i32) / 2..(thickness as i32 + 1) / 2 {

Comments

Conversation

wareya commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wareya commented May 8, 2025

Uh oh!

wareya commented May 8, 2025

Uh oh!

madsmtm left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

wareya commented May 8, 2025 •

edited

Loading

madsmtm left a comment •

edited

Loading